fbdev: sisfb: use explicitly signed char
authorJason A. Donenfeld <Jason@zx2c4.com>
Mon, 24 Oct 2022 16:29:01 +0000 (18:29 +0200)
committerHelge Deller <deller@gmx.de>
Mon, 24 Oct 2022 18:28:41 +0000 (20:28 +0200)
With char becoming unsigned by default, and with `char` alone being
ambiguous and based on architecture, signed chars need to be marked
explicitly as such. This fixes warnings like:

drivers/video/fbdev/sis/init301.c:3549 SiS_GetCRT2Data301() warn: 'SiS_Pr->SiS_EModeIDTable[ModeIdIndex]->ROMMODEIDX661' is unsigned

Cc: Thomas Winischhofer <thomas@winischhofer.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Helge Deller <deller@gmx.de>
Cc: linux-usb@vger.kernel.org
Cc: linux-fbdev@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Signed-off-by: Helge Deller <deller@gmx.de>
drivers/usb/misc/sisusbvga/sisusb_struct.h
drivers/video/fbdev/sis/vstruct.h

index 3df64d2..a86032a 100644 (file)
@@ -91,7 +91,7 @@ struct SiS_Ext {
        unsigned char VB_ExtTVYFilterIndex;
        unsigned char VB_ExtTVYFilterIndexROM661;
        unsigned char REFindex;
-       char ROMMODEIDX661;
+       signed char ROMMODEIDX661;
 };
 
 struct SiS_Ext2 {
index ea94d21..d7a14e6 100644 (file)
@@ -148,7 +148,7 @@ struct SiS_Ext {
        unsigned char  VB_ExtTVYFilterIndex;
        unsigned char  VB_ExtTVYFilterIndexROM661;
        unsigned char  REFindex;
-       char           ROMMODEIDX661;
+       signed char    ROMMODEIDX661;
 };
 
 struct SiS_Ext2 {