cifs: remove redundant variable tcon_exist
authorColin Ian King <colin.i.king@gmail.com>
Tue, 16 Jan 2024 10:51:34 +0000 (10:51 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 25 May 2024 14:22:45 +0000 (16:22 +0200)
[ Upstream commit 8ca5d2641be217a78a891d4dbe2a46232d1d8eb9 ]

The variable tcon_exist is being assigned however it is never read, the
variable is redundant and can be removed.

Cleans up clang scan build warning:
warning: Although the value stored to 'tcon_exist' is used in
the enclosing expression, the value is never actually readfrom
'tcon_exist' [deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/smb/client/smb2pdu.c

index 51ff9a967c50384d9156506a98d1575fd1b1835e..3f9448b5ada9bd88aa8bf894adf30c49215c698a 100644 (file)
@@ -3979,7 +3979,7 @@ void smb2_reconnect_server(struct work_struct *work)
        struct cifs_ses *ses, *ses2;
        struct cifs_tcon *tcon, *tcon2;
        struct list_head tmp_list, tmp_ses_list;
-       bool tcon_exist = false, ses_exist = false;
+       bool ses_exist = false;
        bool tcon_selected = false;
        int rc;
        bool resched = false;
@@ -4025,7 +4025,7 @@ void smb2_reconnect_server(struct work_struct *work)
                        if (tcon->need_reconnect || tcon->need_reopen_files) {
                                tcon->tc_count++;
                                list_add_tail(&tcon->rlist, &tmp_list);
-                               tcon_selected = tcon_exist = true;
+                               tcon_selected = true;
                        }
                }
                /*
@@ -4034,7 +4034,7 @@ void smb2_reconnect_server(struct work_struct *work)
                 */
                if (ses->tcon_ipc && ses->tcon_ipc->need_reconnect) {
                        list_add_tail(&ses->tcon_ipc->rlist, &tmp_list);
-                       tcon_selected = tcon_exist = true;
+                       tcon_selected = true;
                        cifs_smb_ses_inc_refcount(ses);
                }
                /*