SUNRPC: Remove unused argument 'action' from rpc_sleep_on_priority()
authorTrond Myklebust <trondmy@gmail.com>
Sun, 7 Apr 2019 17:58:48 +0000 (13:58 -0400)
committerAnna Schumaker <Anna.Schumaker@Netapp.com>
Thu, 25 Apr 2019 18:18:12 +0000 (14:18 -0400)
None of the callers set the 'action' argument, so let's just remove it.

Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
fs/nfs/nfs4proc.c
include/linux/sunrpc/sched.h
net/sunrpc/sched.c

index 741ff8c9c6ed3f7cda214ec0157eb6d9461ebdca..222eccd8a715b3a0e6051e6e931e62e55b1ce687 100644 (file)
@@ -1008,7 +1008,7 @@ out_start:
 out_sleep:
        if (args->sa_privileged)
                rpc_sleep_on_priority(&tbl->slot_tbl_waitq, task,
-                               NULL, RPC_PRIORITY_PRIVILEGED);
+                               RPC_PRIORITY_PRIVILEGED);
        else
                rpc_sleep_on(&tbl->slot_tbl_waitq, task, NULL);
        spin_unlock(&tbl->slot_tbl_lock);
index 90e06c67f455767d38814c11a4fa077ad8e10034..5d517578a018b888487508a19a35c120c39c719e 100644 (file)
@@ -231,7 +231,6 @@ void                rpc_sleep_on(struct rpc_wait_queue *, struct rpc_task *,
                                        rpc_action action);
 void           rpc_sleep_on_priority(struct rpc_wait_queue *,
                                        struct rpc_task *,
-                                       rpc_action action,
                                        int priority);
 void rpc_wake_up_queued_task_on_wq(struct workqueue_struct *wq,
                struct rpc_wait_queue *queue,
index 8e96a841dd117a3985690fd5cea708175ab87253..04170c08b2cf310629f671c00285feb0a0a8c5fa 100644 (file)
@@ -409,18 +409,17 @@ void rpc_sleep_on(struct rpc_wait_queue *q, struct rpc_task *task,
 EXPORT_SYMBOL_GPL(rpc_sleep_on);
 
 void rpc_sleep_on_priority(struct rpc_wait_queue *q, struct rpc_task *task,
-               rpc_action action, int priority)
+               int priority)
 {
        if (!rpc_sleep_check_activated(task))
                return;
 
-       rpc_set_tk_callback(task, action);
-
+       priority -= RPC_PRIORITY_LOW;
        /*
         * Protect the queue operations.
         */
        spin_lock_bh(&q->lock);
-       __rpc_sleep_on_priority(q, task, priority - RPC_PRIORITY_LOW);
+       __rpc_sleep_on_priority(q, task, priority);
        spin_unlock_bh(&q->lock);
 }
 EXPORT_SYMBOL_GPL(rpc_sleep_on_priority);