tty: synclink_gt: drop info messages from init/exit functions
authorJiri Slaby <jirislaby@kernel.org>
Mon, 31 Jul 2023 08:59:59 +0000 (10:59 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 31 Jul 2023 15:16:20 +0000 (17:16 +0200)
It is preferred NOT to print anything from init and exit functions of a
module. (If everything goes fine.)

Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Link: https://lore.kernel.org/r/20230731090002.15680-5-jirislaby@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/synclink_gt.c

index a8716a8..4a93e0e 100644 (file)
@@ -3628,8 +3628,6 @@ static void slgt_cleanup(void)
        struct slgt_info *info;
        struct slgt_info *tmp;
 
-       printk(KERN_INFO "unload %s\n", driver_name);
-
        if (serial_driver) {
                for (info=slgt_device_list ; info != NULL ; info=info->next_device)
                        tty_unregister_device(serial_driver, info->line);
@@ -3671,8 +3669,6 @@ static int __init slgt_init(void)
 {
        int rc;
 
-       printk(KERN_INFO "%s\n", driver_name);
-
        serial_driver = tty_alloc_driver(MAX_DEVICES, TTY_DRIVER_REAL_RAW |
                        TTY_DRIVER_DYNAMIC_DEV);
        if (IS_ERR(serial_driver)) {
@@ -3701,9 +3697,6 @@ static int __init slgt_init(void)
                goto error;
        }
 
-       printk(KERN_INFO "%s, tty major#%d\n",
-              driver_name, serial_driver->major);
-
        slgt_device_count = 0;
        if ((rc = pci_register_driver(&pci_driver)) < 0) {
                printk("%s pci_register_driver error=%d\n", driver_name, rc);
@@ -3711,9 +3704,6 @@ static int __init slgt_init(void)
        }
        pci_registered = true;
 
-       if (!slgt_device_list)
-               printk("%s no devices found\n",driver_name);
-
        return 0;
 
 error: