net: sparx5: fix error return code in sparx5_register_notifier_blocks()
authorYang Yingliang <yangyingliang@huawei.com>
Sat, 26 Jun 2021 04:44:20 +0000 (12:44 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 28 Jun 2021 21:20:23 +0000 (14:20 -0700)
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: d6fce5141929 ("net: sparx5: add switching support")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/microchip/sparx5/sparx5_switchdev.c

index 246eba7..a72e3b3 100644 (file)
@@ -485,8 +485,10 @@ int sparx5_register_notifier_blocks(struct sparx5 *s5)
                goto err_switchdev_blocking_nb;
 
        sparx5_owq = alloc_ordered_workqueue("sparx5_order", 0);
-       if (!sparx5_owq)
+       if (!sparx5_owq) {
+               err = -ENOMEM;
                goto err_switchdev_blocking_nb;
+       }
 
        return 0;