ASoC: codecs: rt711-sdca: do not store status in state container
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Thu, 18 May 2023 07:27:47 +0000 (09:27 +0200)
committerMark Brown <broonie@kernel.org>
Thu, 18 May 2023 10:25:20 +0000 (19:25 +0900)
Driver in its update status callback stores Soundwire device status in
state container but it never uses it later.  Simplify the code a bit.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com
Link: https://lore.kernel.org/r/20230518072753.7361-7-krzysztof.kozlowski@linaro.org
Signed-off-by: Mark Brown <broonie@kernel.org
sound/soc/codecs/rt711-sdca-sdw.c
sound/soc/codecs/rt711-sdca.h

index 51f3335..2c5eb28 100644 (file)
@@ -143,9 +143,6 @@ static int rt711_sdca_update_status(struct sdw_slave *slave,
 {
        struct rt711_sdca_priv *rt711 = dev_get_drvdata(&slave->dev);
 
-       /* Update the status */
-       rt711->status = status;
-
        if (status == SDW_SLAVE_UNATTACHED)
                rt711->hw_init = false;
 
@@ -168,7 +165,7 @@ static int rt711_sdca_update_status(struct sdw_slave *slave,
         * Perform initialization only if slave status is present and
         * hw_init flag is false
         */
-       if (rt711->hw_init || rt711->status != SDW_SLAVE_ATTACHED)
+       if (rt711->hw_init || status != SDW_SLAVE_ATTACHED)
                return 0;
 
        /* perform I/O transfers required for Slave initialization */
index 22076f2..11d421e 100644 (file)
@@ -19,7 +19,6 @@ struct  rt711_sdca_priv {
        struct regmap *regmap, *mbq_regmap;
        struct snd_soc_component *component;
        struct sdw_slave *slave;
-       enum sdw_slave_status status;
        struct sdw_bus_params params;
        bool hw_init;
        bool first_hw_init;