ASoC: codecs: da7210: add check for i2c_add_driver
authorJiasheng Jiang <jiasheng@iscas.ac.cn>
Tue, 31 May 2022 09:47:12 +0000 (17:47 +0800)
committerMark Brown <broonie@kernel.org>
Mon, 6 Jun 2022 11:38:50 +0000 (12:38 +0100)
As i2c_add_driver could return error if fails, it should be
better to check the return value.
However, if the CONFIG_I2C and CONFIG_SPI_MASTER are both true,
the return value of i2c_add_driver will be covered by
spi_register_driver.
Therefore, it is necessary to add check and return error if fails.

Fixes: aa0e25caafb7 ("ASoC: da7210: Add support for spi regmap")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Link: https://lore.kernel.org/r/20220531094712.2376759-1-jiasheng@iscas.ac.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/da7210.c

index 3fa3042..76a2197 100644 (file)
@@ -1335,6 +1335,8 @@ static int __init da7210_modinit(void)
        int ret = 0;
 #if IS_ENABLED(CONFIG_I2C)
        ret = i2c_add_driver(&da7210_i2c_driver);
+       if (ret)
+               return ret;
 #endif
 #if defined(CONFIG_SPI_MASTER)
        ret = spi_register_driver(&da7210_spi_driver);