usb: musb: remove redundant assignment to variable ret
authorColin Ian King <colin.king@canonical.com>
Wed, 31 Jul 2019 22:39:17 +0000 (23:39 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 1 Aug 2019 16:08:53 +0000 (18:08 +0200)
Variable ret is being initialized with a value that is never read
and ret is being re-assigned a little later on. The assignment is
redundant and hence can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20190731223917.16532-1-colin.king@canonical.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/musb/musb_core.c

index 9f5a481..2bc55e0 100644 (file)
@@ -1721,7 +1721,7 @@ mode_show(struct device *dev, struct device_attribute *attr, char *buf)
 {
        struct musb *musb = dev_to_musb(dev);
        unsigned long flags;
-       int ret = -EINVAL;
+       int ret;
 
        spin_lock_irqsave(&musb->lock, flags);
        ret = sprintf(buf, "%s\n", usb_otg_state_string(musb->xceiv->otg->state));