HID: amd_sfh: Correct the stop all command
authorBasavaraj Natikar <Basavaraj.Natikar@amd.com>
Tue, 11 Apr 2023 16:10:28 +0000 (21:40 +0530)
committerJiri Kosina <jkosina@suse.cz>
Thu, 13 Apr 2023 13:55:22 +0000 (15:55 +0200)
Misinterpreted the stop all command in SHF1.1 firmware. Therefore, it is
necessary to update the stop all command accordingly to disable all
sensors.

Fixes: 93ce5e0231d7 ("HID: amd_sfh: Implement SFH1.1 functionality")
Signed-off-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_interface.c

index 6e19ccc..6f6047f 100644 (file)
@@ -58,8 +58,10 @@ static void amd_stop_all_sensor(struct amd_mp2_dev *privdata)
        struct sfh_cmd_base cmd_base;
 
        cmd_base.ul = 0;
-       cmd_base.cmd.cmd_id = STOP_ALL_SENSORS;
+       cmd_base.cmd.cmd_id = DISABLE_SENSOR;
        cmd_base.cmd.intr_disable = 0;
+       /* 0xf indicates all sensors */
+       cmd_base.cmd.sensor_id = 0xf;
 
        writel(cmd_base.ul, privdata->mmio + AMD_C2P_MSG(0));
 }