platform/x86: asus-wmi: Fix "unsigned 'retval' is never less than zero" smatch warning

Eliminate the follow smatch warnings:

drivers/platform/x86/asus-wmi.c:478 panel_od_write() warn: unsigned
'retval' is never less than zero.

drivers/platform/x86/asus-wmi.c:566 panel_od_write() warn: unsigned
'retval' is never less than zero.

drivers/platform/x86/asus-wmi.c:1451 panel_od_write() warn: unsigned
'retval' is never less than zero.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Fixes: 98829e84dc67 ("asus-wmi: Add dgpu disable method")
Fixes: 382b91db8044 ("asus-wmi: Add egpu enable method")
Fixes: ca91ea34778f ("asus-wmi: Add panel overdrive functionality")
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Link: https://lore.kernel.org/r/1629887822-23918-1-git-send-email-jiapeng.chong@linux.alibaba.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>

diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
index 679429d4126449d51ca632bcf66814ecb66101a8..e14fb5fa73240b0ec3ef7f22d7a677eac8d90066 100644 (file)
--- a/drivers/platform/x86/asus-wmi.c
+++ b/drivers/platform/x86/asus-wmi.c
@@ -475,7 +475,7 @@ static int dgpu_disable_write(struct asus_wmi *asus)
                return err;
        }
 
-       if (retval > 1 || retval < 0) {
+       if (retval > 1) {
                pr_warn("Failed to set dgpu disable (retval): 0x%x\n", retval);
                return -EIO;
        }
@@ -563,7 +563,7 @@ static int egpu_enable_write(struct asus_wmi *asus)
                return err;
        }
 
-       if (retval > 1 || retval < 0) {
+       if (retval > 1) {
                pr_warn("Failed to set egpu disable (retval): 0x%x\n", retval);
                return -EIO;
        }
@@ -1448,7 +1448,7 @@ static int panel_od_write(struct asus_wmi *asus)
                return err;
        }
 
-       if (retval > 1 || retval < 0) {
+       if (retval > 1) {
                pr_warn("Failed to set panel overdrive (retval): 0x%x\n", retval);
                return -EIO;
        }