iio: light: cm36651: Make use of the helper function dev_err_probe()

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Link: https://lore.kernel.org/r/20210928014156.1491-2-caihuoqing@baidu.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

diff --git a/drivers/iio/light/cm36651.c b/drivers/iio/light/cm36651.c
index fd83a19..89f5e48 100644 (file)
--- a/drivers/iio/light/cm36651.c
+++ b/drivers/iio/light/cm36651.c
@@ -632,10 +632,9 @@ static int cm36651_probe(struct i2c_client *client,
        cm36651 = iio_priv(indio_dev);
 
        cm36651->vled_reg = devm_regulator_get(&client->dev, "vled");
-       if (IS_ERR(cm36651->vled_reg)) {
-               dev_err(&client->dev, "get regulator vled failed\n");
-               return PTR_ERR(cm36651->vled_reg);
-       }
+       if (IS_ERR(cm36651->vled_reg))
+               return dev_err_probe(&client->dev, PTR_ERR(cm36651->vled_reg),
+                                    "get regulator vled failed\n");
 
        ret = regulator_enable(cm36651->vled_reg);
        if (ret) {