Only allow non-double if the observed representations are int32.

R=mvstanton@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15988005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14852 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

diff --git a/src/hydrogen-instructions.cc b/src/hydrogen-instructions.cc
index eadac83ed1be76f57d5dfef1c01e151702874a00..069b3f2cbd0d314c72701af391fb1e998ef27ada 100644 (file)
--- a/src/hydrogen-instructions.cc
+++ b/src/hydrogen-instructions.cc
@@ -2460,10 +2460,12 @@ void HCompareIDAndBranch::InferRepresentation(HInferRepresentation* h_infer) {
   Representation observed_right = observed_input_representation(1);
 
   Representation rep = Representation::Smi();
-  if (!left_rep.IsTagged()) rep = rep.generalize(left_rep);
-  if (!right_rep.IsTagged()) rep = rep.generalize(right_rep);
-  if (!observed_left.IsTagged()) rep = rep.generalize(observed_left);
-  if (!observed_right.IsTagged()) rep = rep.generalize(observed_right);
+  if (observed_left.IsInteger32() && observed_right.IsInteger32()) {
+    if (!left_rep.IsTagged()) rep = rep.generalize(left_rep);
+    if (!right_rep.IsTagged()) rep = rep.generalize(right_rep);
+  } else {
+    rep = Representation::Double();
+  }
 
   if (rep.IsDouble()) {
     // According to the ES5 spec (11.9.3, 11.8.5), Equality comparisons (==, ===