projects
/
platform
/
kernel
/
linux-starfive.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
bbc9c36
)
usb: gadget: fsl_qe_udc: validate endpoint index for ch9 udc
author
Ma Ke
<make_ruc2021@163.com>
Wed, 28 Jun 2023 08:15:11 +0000
(16:15 +0800)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Sat, 23 Sep 2023 09:11:07 +0000
(11:11 +0200)
[ Upstream commit
ce9daa2efc0872a9a68ea51dc8000df05893ef2e
]
We should verify the bound of the array to assure that host
may not manipulate the index to point past endpoint array.
Signed-off-by: Ma Ke <make_ruc2021@163.com>
Acked-by: Li Yang <leoyang.li@nxp.com>
Link:
https://lore.kernel.org/r/20230628081511.186850-1-make_ruc2021@163.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/usb/gadget/udc/fsl_qe_udc.c
patch
|
blob
|
history
diff --git
a/drivers/usb/gadget/udc/fsl_qe_udc.c
b/drivers/usb/gadget/udc/fsl_qe_udc.c
index
3b1cc8f
..
72b6d74
100644
(file)
--- a/
drivers/usb/gadget/udc/fsl_qe_udc.c
+++ b/
drivers/usb/gadget/udc/fsl_qe_udc.c
@@
-1959,9
+1959,13
@@
static void ch9getstatus(struct qe_udc *udc, u8 request_type, u16 value,
} else if ((request_type & USB_RECIP_MASK) == USB_RECIP_ENDPOINT) {
/* Get endpoint status */
int pipe = index & USB_ENDPOINT_NUMBER_MASK;
- struct qe_ep *target_ep
= &udc->eps[pipe]
;
+ struct qe_ep *target_ep;
u16 usep;
+ if (pipe >= USB_MAX_ENDPOINTS)
+ goto stall;
+ target_ep = &udc->eps[pipe];
+
/* stall if endpoint doesn't exist */
if (!target_ep->ep.desc)
goto stall;