extcon: arizona: Remove excessive WARN_ON
authorCharles Keepax <ckeepax@opensource.cirrus.com>
Mon, 9 Dec 2019 11:09:13 +0000 (11:09 +0000)
committerChanwoo Choi <cw00.choi@samsung.com>
Mon, 9 Dec 2019 11:18:14 +0000 (20:18 +0900)
A WARN_ON is very strong for simply finding a button that is out of
range, downgrade this to a simple error message in the log.

Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
drivers/extcon/extcon-arizona.c

index e7c198e..3f7ced3 100644 (file)
@@ -960,14 +960,13 @@ static void arizona_micd_detect(struct work_struct *work)
                                input_report_key(info->input,
                                                 info->micd_ranges[i].key, 0);
 
-                       WARN_ON(!lvl);
-                       WARN_ON(ffs(lvl) - 1 >= info->num_micd_ranges);
                        if (lvl && ffs(lvl) - 1 < info->num_micd_ranges) {
                                key = info->micd_ranges[ffs(lvl) - 1].key;
                                input_report_key(info->input, key, 1);
                                input_sync(info->input);
+                       } else {
+                               dev_err(arizona->dev, "Button out of range\n");
                        }
-
                } else if (info->detecting) {
                        dev_dbg(arizona->dev, "Headphone detected\n");
                        info->detecting = false;