iio: adc: Add check for devm_request_threaded_irq
authorJiasheng Jiang <jiasheng@iscas.ac.cn>
Thu, 24 Feb 2022 06:28:49 +0000 (14:28 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 8 Apr 2022 12:23:46 +0000 (14:23 +0200)
[ Upstream commit b30537a4cedcacf0ade2f33ebb7610178ed1e7d7 ]

As the potential failure of the devm_request_threaded_irq(),
it should be better to check the return value and return
error if fails.

Fixes: fa659a40b80b ("iio: adc: twl6030-gpadc: Use devm_* API family")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Link: https://lore.kernel.org/r/20220224062849.3280966-1-jiasheng@iscas.ac.cn
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/iio/adc/twl6030-gpadc.c

index c6416ad..256177b 100644 (file)
@@ -911,6 +911,8 @@ static int twl6030_gpadc_probe(struct platform_device *pdev)
        ret = devm_request_threaded_irq(dev, irq, NULL,
                                twl6030_gpadc_irq_handler,
                                IRQF_ONESHOT, "twl6030_gpadc", indio_dev);
+       if (ret)
+               return ret;
 
        ret = twl6030_gpadc_enable_irq(TWL6030_GPADC_RT_SW1_EOC_MASK);
        if (ret < 0) {