Fix unnecessary passing parameter by value

- Static analyzer issue

Change-Id: Ieab4205d45956942316ded0e06aa5c2f2774a328
Signed-off-by: hyunho <hhstark.kang@samsung.com>

diff --git a/component_based/app_control/component_based_app_control.cc b/component_based/app_control/component_based_app_control.cc
index b1846e76406ce52d2e871d31152b6fc0824cc7b6..3d0ff131555384efc5dc14a13cb2a2c399220e84 100644 (file)
--- a/component_based/app_control/component_based_app_control.cc
+++ b/component_based/app_control/component_based_app_control.cc
@@ -52,8 +52,8 @@ AppControl::Builder& AppControl::Builder::SetOperation(std::string op) {
   return *this;
 }
 
-AppControl::Builder& AppControl::Builder::SetUri(Uri uri) {
-  uri_ = std::move(uri);
+AppControl::Builder& AppControl::Builder::SetUri(Uri& uri) {
+  uri_ = uri;
   return *this;
 }
 

diff --git a/component_based/app_control/component_based_app_control.h b/component_based/app_control/component_based_app_control.h
index 1d3e08827b279e37749604c8f79ea5a71aa1a05b..8ecba0a427a5d6a9ad7656d420c545a209bce9a8 100644 (file)
--- a/component_based/app_control/component_based_app_control.h
+++ b/component_based/app_control/component_based_app_control.h
@@ -74,7 +74,7 @@ class EXPORT_API AppControl {
     virtual ~Builder();
     Builder& SetAppID(std::string appid);
     Builder& SetOperation(std::string op);
-    Builder& SetUri(Uri uri);
+    Builder& SetUri(Uri& uri);
     Builder& SetMime(std::string mime);
     Builder& AddExtra(std::string key, std::string val);
     Builder& SetLaunchMode(AppControl::LaunchMode mode);

diff --git a/unit_tests/src/base/test_component_based_component.cc b/unit_tests/src/base/test_component_based_component.cc
index 249a0fc86e367dbd25883c180279f1a8a9cafb0c..c86b3eba601d97c704310c07c1476210ef6a7496 100644 (file)
--- a/unit_tests/src/base/test_component_based_component.cc
+++ b/unit_tests/src/base/test_component_based_component.cc
@@ -75,7 +75,10 @@ TEST_F(ComponentTest, TestFrameComponentClass) {
   builder->SetAppID("org.tizen.helloworld");
   builder->SetOperation(APP_CONTROL_OPERATION_DEFAULT);
   builder->SetLaunchMode(component_based::AppControl::LaunchMode::SINGLE);
-  builder->SetUri(component_based::Uri("https:%2F%2Fjohn.doe%40www.example.com%3A123%2Fforum%2Fquestions%2F?tag=networking&order=newest#top"));
+
+  component_based::Uri uri(
+    "https:%2F%2Fjohn.doe%40www.example.com%3A123%2Fforum%2Fquestions%2F?tag=networking&order=newest#top");
+  builder->SetUri(uri);
   builder->SetMime("application/octet-stream");
   builder->AddExtra("key", "value");
   builder->SetComponentID("ElmFrame");
@@ -106,7 +109,9 @@ TEST_F(ComponentTest, TestSerivceComponentClass) {
   builder->SetAppID("org.tizen.helloworld");
   builder->SetOperation(APP_CONTROL_OPERATION_DEFAULT);
   builder->SetLaunchMode(component_based::AppControl::LaunchMode::SINGLE);
-  builder->SetUri(component_based::Uri("https:%2F%2Fjohn.doe%40www.example.com%3A123%2Fforum%2Fquestions%2F?tag=networking&order=newest#top"));
+  component_based::Uri uri(
+    "https:%2F%2Fjohn.doe%40www.example.com%3A123%2Fforum%2Fquestions%2F?tag=networking&order=newest#top");
+  builder->SetUri(uri);
   builder->SetMime("application/octet-stream");
   builder->AddExtra("key", "value");
   builder->SetComponentID("ElmFrame");
@@ -145,7 +150,9 @@ TEST_F(ComponentTest, TestComponentClass) {
   builder->SetAppID("org.tizen.helloworld");
   builder->SetOperation(APP_CONTROL_OPERATION_DEFAULT);
   builder->SetLaunchMode(component_based::AppControl::LaunchMode::SINGLE);
-  builder->SetUri(component_based::Uri("https:%2F%2Fjohn.doe%40www.example.com%3A123%2Fforum%2Fquestions%2F?tag=networking&order=newest#top"));
+  component_based::Uri uri(
+    "https:%2F%2Fjohn.doe%40www.example.com%3A123%2Fforum%2Fquestions%2F?tag=networking&order=newest#top");
+  builder->SetUri(uri);
   builder->SetMime("application/octet-stream");
   builder->AddExtra("key", "value");
   builder->SetComponentID("ElmFrame");

diff --git a/unit_tests/src/test_component_based_app_control.cc b/unit_tests/src/test_component_based_app_control.cc
index e2efe32380173b1172952843cbbbb630f99bbbec..fff17b5706776fc33d5002ab42816e7e5927d8c4 100644 (file)
--- a/unit_tests/src/test_component_based_app_control.cc
+++ b/unit_tests/src/test_component_based_app_control.cc
@@ -40,7 +40,9 @@ TEST_F(AppControlTest, AppControl_Builder) {
   builder->SetAppID("org.tizen.helloworld");
   builder->SetOperation(APP_CONTROL_OPERATION_DEFAULT);
   builder->SetLaunchMode(component_based::AppControl::LaunchMode::SINGLE);
-  builder->SetUri(component_based::Uri(ENCODED_URI));
+
+  component_based::Uri uri(ENCODED_URI);
+  builder->SetUri(uri);
   builder->SetMime(MIME_TYPE);
   builder->AddExtra("key", "value");
   builder->SetComponentID("ElmFrame");
@@ -64,7 +66,9 @@ TEST_F(AppControlTest, AppControl_Constructor) {
   builder->SetAppID("org.tizen.helloworld");
   builder->SetOperation(APP_CONTROL_OPERATION_DEFAULT);
   builder->SetLaunchMode(component_based::AppControl::LaunchMode::SINGLE);
-  builder->SetUri(component_based::Uri(ENCODED_URI));
+
+  component_based::Uri uri(ENCODED_URI);
+  builder->SetUri(uri);
   builder->SetMime(MIME_TYPE);
   builder->AddExtra("key", "value");
   builder->SetComponentID("ElmFrame");