smb3: add missing null server pointer check

commit 45be0882c5f91e1b92e645001dd1a53b3bd58c97 upstream.

Address static checker warning in cifs_ses_get_chan_index():
    warn: variable dereferenced before check 'server'
To be consistent, and reduce risk, we should add another check
for null server pointer.

Fixes: 88675b22d34e ("cifs: do not search for channel if server is terminating")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Shyam Prasad N <sprasad@microsoft.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/fs/smb/client/sess.c b/fs/smb/client/sess.c
index 07726b456a0a87a34bdc8e9b86fa42c977fadbc0..2fc2fbb260bf0da49ad043a016b4859f71785aeb 100644 (file)
--- a/fs/smb/client/sess.c
+++ b/fs/smb/client/sess.c
@@ -76,7 +76,7 @@ cifs_ses_get_chan_index(struct cifs_ses *ses,
        unsigned int i;
 
        /* if the channel is waiting for termination */
-       if (server->terminate)
+       if (server && server->terminate)
                return CIFS_INVAL_CHAN_INDEX;
 
        for (i = 0; i < ses->chan_count; i++) {