mmc: cavium-octeon: Use devm_platform_ioremap_resource()
authorMarkus Elfring <elfring@users.sourceforge.net>
Wed, 18 Sep 2019 12:20:34 +0000 (14:20 +0200)
committerUlf Hansson <ulf.hansson@linaro.org>
Wed, 13 Nov 2019 15:10:16 +0000 (16:10 +0100)
Simplify this function implementation by using a known wrapper function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/cavium-octeon.c

index 22aded1..916746c 100644 (file)
@@ -148,7 +148,6 @@ static int octeon_mmc_probe(struct platform_device *pdev)
 {
        struct device_node *cn, *node = pdev->dev.of_node;
        struct cvm_mmc_host *host;
-       struct resource *res;
        void __iomem *base;
        int mmc_irq[9];
        int i, ret = 0;
@@ -205,23 +204,13 @@ static int octeon_mmc_probe(struct platform_device *pdev)
 
        host->last_slot = -1;
 
-       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       if (!res) {
-               dev_err(&pdev->dev, "Platform resource[0] is missing\n");
-               return -ENXIO;
-       }
-       base = devm_ioremap_resource(&pdev->dev, res);
+       base = devm_platform_ioremap_resource(pdev, 0);
        if (IS_ERR(base))
                return PTR_ERR(base);
        host->base = (void __iomem *)base;
        host->reg_off = 0;
 
-       res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
-       if (!res) {
-               dev_err(&pdev->dev, "Platform resource[1] is missing\n");
-               return -EINVAL;
-       }
-       base = devm_ioremap_resource(&pdev->dev, res);
+       base = devm_platform_ioremap_resource(pdev, 1);
        if (IS_ERR(base))
                return PTR_ERR(base);
        host->dma_base = (void __iomem *)base;