vfio/fsl-mc: fix the return of the uninitialized variable ret
authorDiana Craciun <diana.craciun@oss.nxp.com>
Fri, 16 Oct 2020 09:32:32 +0000 (12:32 +0300)
committerAlex Williamson <alex.williamson@redhat.com>
Mon, 19 Oct 2020 13:09:41 +0000 (07:09 -0600)
The vfio_fsl_mc_reflck_attach function may return, on success path,
an uninitialized variable. Fix the problem by initializing the return
variable to 0.

Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: f2ba7e8c947b ("vfio/fsl-mc: Added lock support in preparation for interrupt handling")
Reported-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Diana Craciun <diana.craciun@oss.nxp.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
drivers/vfio/fsl-mc/vfio_fsl_mc.c

index 80fc7f4..0113a98 100644 (file)
@@ -58,7 +58,7 @@ static struct vfio_fsl_mc_reflck *vfio_fsl_mc_reflck_alloc(void)
 
 static int vfio_fsl_mc_reflck_attach(struct vfio_fsl_mc_device *vdev)
 {
-       int ret;
+       int ret = 0;
 
        mutex_lock(&reflck_lock);
        if (is_fsl_mc_bus_dprc(vdev->mc_dev)) {