[lldb][NFC] Remove DiagnosticManager::CopyDiagnostics
authorRaphael Isemann <teemperor@gmail.com>
Mon, 29 Jul 2019 07:37:17 +0000 (07:37 +0000)
committerRaphael Isemann <teemperor@gmail.com>
Mon, 29 Jul 2019 07:37:17 +0000 (07:37 +0000)
The Diagnostic class in LLDB is suppossed to be inherited from,
so just copying the diagnostics like this is wrong. The function
is also unused, so lets just get rid of it instead of creating
some cloning facility for it.

llvm-svn: 367201

lldb/include/lldb/Expression/DiagnosticManager.h
lldb/source/Expression/DiagnosticManager.cpp

index 557b941..472ae0e 100644 (file)
@@ -125,8 +125,6 @@ public:
     m_diagnostics.push_back(diagnostic);
   }
 
-  void CopyDiagnostics(DiagnosticManager &otherDiagnostics);
-
   size_t Printf(DiagnosticSeverity severity, const char *format, ...)
       __attribute__((format(printf, 3, 4)));
   size_t PutString(DiagnosticSeverity severity, llvm::StringRef str);
index 53d85f8..b258ede 100644 (file)
@@ -77,12 +77,3 @@ size_t DiagnosticManager::PutString(DiagnosticSeverity severity,
   AddDiagnostic(str, severity, eDiagnosticOriginLLDB);
   return str.size();
 }
-
-void DiagnosticManager::CopyDiagnostics(DiagnosticManager &otherDiagnostics) {
-  for (const DiagnosticList::value_type &other_diagnostic:
-       otherDiagnostics.Diagnostics()) {
-    AddDiagnostic(
-        other_diagnostic->GetMessage(), other_diagnostic->GetSeverity(),
-        other_diagnostic->getKind(), other_diagnostic->GetCompilerID());
-  }
-}