tle62x0 driver stops ignoring read errors
authorDavid Brownell <david-b@pacbell.net>
Thu, 15 Nov 2007 01:00:04 +0000 (17:00 -0800)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Thu, 15 Nov 2007 02:45:42 +0000 (18:45 -0800)
The tle62x0 driver was ignoring all read errors.  This patch makes it
pass such errors up the stack, instead of returning bogus data.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/spi/tle62x0.c

index 6da58ca..455991f 100644 (file)
@@ -107,8 +107,11 @@ static ssize_t tle62x0_status_show(struct device *dev,
 
        mutex_lock(&st->lock);
        ret = tle62x0_read(st);
-
        dev_dbg(dev, "tle62x0_read() returned %d\n", ret);
+       if (ret < 0) {
+               mutex_unlock(&st->lock);
+               return ret;
+       }
 
        for (ptr = 0; ptr < (st->nr_gpio * 2)/8; ptr += 1) {
                fault <<= 8;