cifsd: use kfree to free memory allocated by kmalloc or kzalloc

kfree should be used to free memory allocated by kmalloc or kzalloc to
avoid any overhead and for maintaining consistency.

Signed-off-by: Muhammad Usama Anjum <musamaanjum@gmail.com>
Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Steve French <stfrench@microsoft.com>

diff --git a/fs/cifsd/buffer_pool.c b/fs/cifsd/buffer_pool.c
index ad2a2c885a2cecfd5854192585cca2d2541f6716..a9ef3e7032326b852217ef7cb3d86b6d60d153b0 100644 (file)
--- a/fs/cifsd/buffer_pool.c
+++ b/fs/cifsd/buffer_pool.c
@@ -78,7 +78,7 @@ static int register_wm_size_class(size_t sz)
        list_for_each_entry(l, &wm_lists, list) {
                if (l->sz == sz) {
                        write_unlock(&wm_lists_lock);
-                       kvfree(nl);
+                       kfree(nl);
                        return 0;
                }
        }
@@ -181,7 +181,7 @@ static void wm_list_free(struct wm_list *l)
                list_del(&wm->list);
                kvfree(wm);
        }
-       kvfree(l);
+       kfree(l);
 }
 
 static void wm_lists_destroy(void)

diff --git a/fs/cifsd/mgmt/share_config.c b/fs/cifsd/mgmt/share_config.c
index b2bd789af945fe6f8476a2a66443db14b1638143..11abdbc8a53349eb3d2cbb430b350b2db56791f1 100644 (file)
--- a/fs/cifsd/mgmt/share_config.c
+++ b/fs/cifsd/mgmt/share_config.c
@@ -102,7 +102,7 @@ static int parse_veto_list(struct ksmbd_share_config *share,
 
                p->pattern = kstrdup(veto_list, GFP_KERNEL);
                if (!p->pattern) {
-                       ksmbd_free(p);
+                       kfree(p);
                        return -ENOMEM;
                }
 

diff --git a/fs/cifsd/mgmt/user_config.c b/fs/cifsd/mgmt/user_config.c
index f0c2f8994a6b83bb5d90f87c14cc1ecd7d97261a..c31e2c4d2d6f2e24cf45a0919a3965432bc769a0 100644 (file)
--- a/fs/cifsd/mgmt/user_config.c
+++ b/fs/cifsd/mgmt/user_config.c
@@ -46,8 +46,8 @@ struct ksmbd_user *ksmbd_alloc_user(struct ksmbd_login_response *resp)
 
        if (!user->name || !user->passkey) {
                kfree(user->name);
-               ksmbd_free(user->passkey);
-               ksmbd_free(user);
+               kfree(user->passkey);
+               kfree(user);
                user = NULL;
        }
        return user;
@@ -57,8 +57,8 @@ void ksmbd_free_user(struct ksmbd_user *user)
 {
        ksmbd_ipc_logout_request(user->name);
        kfree(user->name);
-       ksmbd_free(user->passkey);
-       ksmbd_free(user);
+       kfree(user->passkey);
+       kfree(user);
 }
 
 int ksmbd_anonymous_user(struct ksmbd_user *user)

diff --git a/fs/cifsd/mgmt/user_session.c b/fs/cifsd/mgmt/user_session.c
index f5cc7a62d8488577497a4beeeddae50242537521..9dfe222e51abc98c6273a24de22397e60a5e1e90 100644 (file)
--- a/fs/cifsd/mgmt/user_session.c
+++ b/fs/cifsd/mgmt/user_session.c
@@ -55,7 +55,7 @@ static void __session_rpc_close(struct ksmbd_session *sess,
 
        ksmbd_free(resp);
        ksmbd_rpc_id_free(entry->id);
-       ksmbd_free(entry);
+       kfree(entry);
 }
 
 static void ksmbd_session_rpc_clear_list(struct ksmbd_session *sess)
@@ -121,7 +121,7 @@ int ksmbd_session_rpc_open(struct ksmbd_session *sess, char *rpc_name)
        return entry->id;
 error:
        list_del(&entry->list);
-       ksmbd_free(entry);
+       kfree(entry);
        return -EINVAL;
 }
 
@@ -176,7 +176,7 @@ void ksmbd_session_destroy(struct ksmbd_session *sess)
        ksmbd_release_id(session_ida, sess->id);
 
        ksmbd_ida_free(sess->tree_conn_ida);
-       ksmbd_free(sess);
+       kfree(sess);
 }
 
 static struct ksmbd_session *__session_lookup(unsigned long long id)

diff --git a/fs/cifsd/smb2pdu.c b/fs/cifsd/smb2pdu.c
index 0b7199444f730843f5bba7e34bf58ba431abf37c..7549b35bb7926142a6a1be768ca8b2b22b3e24b7 100644 (file)
--- a/fs/cifsd/smb2pdu.c
+++ b/fs/cifsd/smb2pdu.c
@@ -1611,7 +1611,7 @@ int smb2_sess_setup(struct ksmbd_work *work)
 
                        ksmbd_conn_set_good(work);
                        sess->state = SMB2_SESSION_VALID;
-                       ksmbd_free(sess->Preauth_HashValue);
+                       kfree(sess->Preauth_HashValue);
                        sess->Preauth_HashValue = NULL;
                } else if (conn->preferred_auth_mech == KSMBD_AUTH_NTLMSSP) {
                        rc = generate_preauth_hash(work);
@@ -1637,7 +1637,7 @@ int smb2_sess_setup(struct ksmbd_work *work)
 
                                ksmbd_conn_set_good(work);
                                sess->state = SMB2_SESSION_VALID;
-                               ksmbd_free(sess->Preauth_HashValue);
+                               kfree(sess->Preauth_HashValue);
                                sess->Preauth_HashValue = NULL;
                        }
                } else {

diff --git a/fs/cifsd/transport_tcp.c b/fs/cifsd/transport_tcp.c
index 67163efcf47262f6b33a7c070b04432a1ee6760b..040881893417b098ae92fb84ef5f23c581abf48f 100644 (file)
--- a/fs/cifsd/transport_tcp.c
+++ b/fs/cifsd/transport_tcp.c
@@ -551,7 +551,7 @@ void ksmbd_tcp_destroy(void)
        list_for_each_entry_safe(iface, tmp, &iface_list, entry) {
                list_del(&iface->entry);
                kfree(iface->name);
-               ksmbd_free(iface);
+               kfree(iface);
        }
 }
 

diff --git a/fs/cifsd/vfs_cache.c b/fs/cifsd/vfs_cache.c
index ec631dc6f1fb48773f68154d89560c79db47e432..f2a863542dc711e8aad9121a0b0fc6c02edcc4f6 100644 (file)
--- a/fs/cifsd/vfs_cache.c
+++ b/fs/cifsd/vfs_cache.c
@@ -829,6 +829,6 @@ void ksmbd_destroy_file_table(struct ksmbd_file_table *ft)
 
        __close_file_table_ids(ft, NULL, session_fd_check);
        idr_destroy(ft->idr);
-       ksmbd_free(ft->idr);
+       kfree(ft->idr);
        ft->idr = NULL;
 }