misc: ibmasm: remove unnecessary pci_set_drvdata()
authorJingoo Han <jg1.han@samsung.com>
Mon, 23 Sep 2013 01:36:24 +0000 (10:36 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 26 Sep 2013 16:13:54 +0000 (09:13 -0700)
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/ibmasm/module.c

index 0c290e4..6b3bf9a 100644 (file)
@@ -153,7 +153,6 @@ error_ioremap:
 error_heartbeat:
        ibmasm_event_buffer_exit(sp);
 error_eventbuffer:
-       pci_set_drvdata(pdev, NULL);
        kfree(sp);
 error_kmalloc:
         pci_release_regions(pdev);
@@ -182,7 +181,6 @@ static void ibmasm_remove_one(struct pci_dev *pdev)
        ibmasm_free_remote_input_dev(sp);
        iounmap(sp->base_address);
        ibmasm_event_buffer_exit(sp);
-       pci_set_drvdata(pdev, NULL);
        kfree(sp);
        pci_release_regions(pdev);
        pci_disable_device(pdev);