scsi: lpfc: Fix release of hwq to clear the eq relationship
authorJames Smart <jsmart2021@gmail.com>
Tue, 28 Jan 2020 00:23:05 +0000 (16:23 -0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 11 Feb 2020 03:46:55 +0000 (22:46 -0500)
When performing reset testing, the eq's list for related hwqs was getting
corrupted.  In cases where there is not a 1:1 eq to hwq, the eq is
shared. The eq maintains a list of hwqs utilizing it in case of cpu
offlining and polling. During the reset, the hwqs are being torn down so
they can be recreated. The recreation was getting confused by seeing a
non-null eq assignment on the eq and the eq list became corrupt.

Correct by clearing the hdwq eq assignment when the hwq is cleaned up.

Link: https://lore.kernel.org/r/20200128002312.16346-6-jsmart2021@gmail.com
Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: James Smart <jsmart2021@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/lpfc/lpfc_init.c

index 5a60577..9fd238d 100644 (file)
@@ -9235,6 +9235,7 @@ lpfc_sli4_release_hdwq(struct lpfc_hba *phba)
                /* Free the CQ/WQ corresponding to the Hardware Queue */
                lpfc_sli4_queue_free(hdwq[idx].io_cq);
                lpfc_sli4_queue_free(hdwq[idx].io_wq);
+               hdwq[idx].hba_eq = NULL;
                hdwq[idx].io_cq = NULL;
                hdwq[idx].io_wq = NULL;
                if (phba->cfg_xpsgl && !phba->nvmet_support)