ASoC: wm8998: Fix PM disable depth imbalance on error
authorZhang Qilong <zhangqilong3@huawei.com>
Wed, 11 Nov 2020 04:13:26 +0000 (12:13 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 Dec 2020 10:53:08 +0000 (11:53 +0100)
[ Upstream commit 193aa0a043645220d2a2f783ba06ae13d4601078 ]

The pm_runtime_enable will increase power disable depth. Thus
a pairing decrement is needed on the error handling path to
keep it balanced according to context.

Fixes: 31833ead95c2c ("ASoC: arizona: Move request of speaker IRQs into bus probe")
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
Reviewed-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20201111041326.1257558-4-zhangqilong3@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/soc/codecs/wm8998.c

index f6c5cc80c970b6507e806665b110b2c0bf04e72c..5413254295b70dfe608fd39f31eb521fb63aefd2 100644 (file)
@@ -1375,7 +1375,7 @@ static int wm8998_probe(struct platform_device *pdev)
 
        ret = arizona_init_spk_irqs(arizona);
        if (ret < 0)
-               return ret;
+               goto err_pm_disable;
 
        ret = devm_snd_soc_register_component(&pdev->dev,
                                              &soc_component_dev_wm8998,
@@ -1390,6 +1390,8 @@ static int wm8998_probe(struct platform_device *pdev)
 
 err_spk_irqs:
        arizona_free_spk_irqs(arizona);
+err_pm_disable:
+       pm_runtime_disable(&pdev->dev);
 
        return ret;
 }