Fix coverity issues

dynamic_cast can be NULL

Change-Id: I8b68b6b2c0000a1dc33deb5a8665695096904b8b

diff --git a/packaging/capi-media-metadata-editor.spec b/packaging/capi-media-metadata-editor.spec
index 8d9807b..fc80a35 100755 (executable)
--- a/packaging/capi-media-metadata-editor.spec
+++ b/packaging/capi-media-metadata-editor.spec
@@ -1,6 +1,6 @@
 Name:       capi-media-metadata-editor
 Summary:    A metadata editor library in Tizen Native API
-Version: 0.2.0
+Version: 0.2.1
 Release:    0
 Group:      Multimedia/API
 License:    Apache-2.0

diff --git a/src/metadata_editor.cpp b/src/metadata_editor.cpp
index a64b2b8..048986c 100755 (executable)
--- a/src/metadata_editor.cpp
+++ b/src/metadata_editor.cpp
@@ -1328,7 +1328,10 @@ static int __append_APIC(ID3v2::Tag *tag, const char *picture, size_t size, cons
 }
 static int __append_mp3_picture(metadata_editor_s *metadata, const char *picture ,size_t size, const char *mime_type)
 {
-       return __append_APIC(dynamic_cast<MPEG::File*>(metadata->file)->ID3v2Tag(true), picture, size, mime_type);
+       auto _file = dynamic_cast<MPEG::File*>(metadata->file);
+       metadata_editor_retvm_if(!_file, METADATA_EDITOR_ERROR_OPERATION_FAILED, "fail to dynamic_cast");
+
+       return __append_APIC(_file->ID3v2Tag(true), picture, size, mime_type);
 }
 
 static int __append_mp4_picture(metadata_editor_s *metadata, const char *picture, size_t size, const char *mime_type)
@@ -1480,7 +1483,10 @@ static int __remove_APIC(ID3v2::Tag *tag, int index)
 }
 static int __remove_mp3_picture(metadata_editor_s *metadata, int index)
 {
-       return __remove_APIC(dynamic_cast<MPEG::File*>(metadata->file)->ID3v2Tag(true), index);
+       auto _file = dynamic_cast<MPEG::File*>(metadata->file);
+       metadata_editor_retvm_if(!_file, METADATA_EDITOR_ERROR_OPERATION_FAILED, "fail to dynamic_cast");
+
+       return __remove_APIC(_file->ID3v2Tag(true), index);
 }
 
 static int __remove_mp4_picture(metadata_editor_s *metadata, int index)