mmc: mmc_spi: fix timeout calculation
authorTobias Schramm <t.schramm@manjaro.org>
Fri, 14 Aug 2020 18:50:11 +0000 (20:50 +0200)
committerUlf Hansson <ulf.hansson@linaro.org>
Mon, 7 Sep 2020 07:11:29 +0000 (09:11 +0200)
Previously the cycle timeout was converted to a microsecond value but
then incorrectly treated as a nanosecond timeout. This patch changes
the code to convert both the nanosecond timeout and the cycle timeout
to a microsecond value and use that directly.

Signed-off-by: Tobias Schramm <t.schramm@manjaro.org>
Link: https://lore.kernel.org/r/20200814185011.3252020-1-t.schramm@manjaro.org
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/mmc_spi.c

index 39bb1e3..f85e0ad 100644 (file)
@@ -882,9 +882,9 @@ mmc_spi_data_do(struct mmc_spi_host *host, struct mmc_command *cmd,
        else
                clock_rate = spi->max_speed_hz;
 
-       timeout = data->timeout_ns +
+       timeout = data->timeout_ns / 1000 +
                  data->timeout_clks * 1000000 / clock_rate;
-       timeout = usecs_to_jiffies((unsigned int)(timeout / 1000)) + 1;
+       timeout = usecs_to_jiffies((unsigned int)timeout) + 1;
 
        /* Handle scatterlist segments one at a time, with synch for
         * each 512-byte block