Revert "wl_egl: add exception checking to find invalid wl_egl_buffer" 72/314272/1
authorjinbong.lee <jinbong.lee@samsung.com>
Tue, 9 Jul 2024 12:35:50 +0000 (12:35 +0000)
committerjinbong.lee <jinbong.lee@samsung.com>
Tue, 9 Jul 2024 12:41:27 +0000 (12:41 +0000)
This reverts commit c74b4ab60aa2a82a66b01fac6125af0566fc73da.
 - That exception check doesn't protected with wl_egl_surface->buffers_mutex.
 - _thread_wl_surface_commit function is called inside of wl_egl_buffer->mutex is locked.
 - It means wl_egl_buffer is available when _thread_wl_surface_commit is called.
 - If wl_egl_surface->buffers_mutex is used inside of wl_egl_buffer->mutex then deadlock will be occurred.

Change-Id: I688f963827590f045bd3f97a7d6298e5281fb6e1

src/tpl_wl_egl_thread.c

index 5fccfd51ba516b228e4f8515ae4b842825cb52a8..a514131883cbc41001180bc7689bf4730704a67a 100755 (executable)
@@ -3678,12 +3678,6 @@ _thread_wl_surface_commit(tpl_wl_egl_surface_t *wl_egl_surface,
        TPL_CHECK_ON_FALSE_ASSERT_FAIL(wl_egl_buffer != NULL,
                                                                   "wl_egl_buffer sould be not NULL");
 
-       if (__tpl_list_get_count(wl_egl_surface->buffers) == 0) {
-               TPL_ERR("wl_egl_buffer(%p) already has been removed from wl_egl_surface(%p)",
-                               wl_egl_buffer, wl_egl_surface);
-               return;
-       }
-
        if (wl_egl_buffer->wl_buffer == NULL) {
                wl_egl_buffer->wl_buffer =
                        (struct wl_proxy *)wayland_tbm_client_create_buffer(