scsi: qla2xxx: Remove two superfluous casts
authorBart Van Assche <bvanassche@acm.org>
Thu, 11 Apr 2019 21:53:24 +0000 (14:53 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 16 Apr 2019 02:04:40 +0000 (22:04 -0400)
Casting a void pointer into another pointer before assigning the pointer to
a variable is not useful. Hence remove such casts.

Cc: Himanshu Madhani <hmadhani@marvell.com>
Cc: Giridhar Malavali <gmalavali@marvell.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Acked-by: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla2xxx/qla_target.c

index 3bf4d15..57cdd76 100644 (file)
@@ -4037,7 +4037,7 @@ static void qlt_do_ctio_completion(struct scsi_qla_host *vha,
                return;
        }
 
-       cmd = (struct qla_tgt_cmd *)qlt_ctio_to_cmd(vha, rsp, handle, ctio);
+       cmd = qlt_ctio_to_cmd(vha, rsp, handle, ctio);
        if (cmd == NULL)
                return;
 
@@ -5831,8 +5831,7 @@ static void qlt_handle_abts_completion(struct scsi_qla_host *vha,
        struct qla_tgt_mgmt_cmd *mcmd;
        struct qla_hw_data *ha = vha->hw;
 
-       mcmd = (struct qla_tgt_mgmt_cmd *)qlt_ctio_to_cmd(vha, rsp,
-           pkt->handle, pkt);
+       mcmd = qlt_ctio_to_cmd(vha, rsp, pkt->handle, pkt);
        if (mcmd == NULL && h != QLA_TGT_SKIP_HANDLE) {
                ql_dbg(ql_dbg_async, vha, 0xe064,
                    "qla_target(%d): ABTS Comp without mcmd\n",