video: fbdev: mmp: Make use of the helper function dev_err_probe()

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Signed-off-by: Helge Deller <deller@gmx.de>

diff --git a/drivers/video/fbdev/mmp/hw/mmp_ctrl.c b/drivers/video/fbdev/mmp/hw/mmp_ctrl.c
index 061a105..a9df8ee 100644 (file)
--- a/drivers/video/fbdev/mmp/hw/mmp_ctrl.c
+++ b/drivers/video/fbdev/mmp/hw/mmp_ctrl.c
@@ -514,7 +514,8 @@ static int mmphw_probe(struct platform_device *pdev)
        /* get clock */
        ctrl->clk = devm_clk_get(ctrl->dev, mi->clk_name);
        if (IS_ERR(ctrl->clk)) {
-               dev_err(ctrl->dev, "unable to get clk %s\n", mi->clk_name);
+               dev_err_probe(ctrl->dev, ret,
+                             "unable to get clk %s\n", mi->clk_name);
                ret = -ENOENT;
                goto failed;
        }