lib: sbi: fix sbi_domain_get_assigned_hartmask()

'1' is a 32 bit integer. When shifting it by more than 31 bits it becomes
zero and we get an incorrect return value.

Addresses-Coverity-ID: 1568356 Bad bit shift operation
Fixes: 296e70d69da7 ("lib: sbi: Extend sbi_hartmask to support both hartid and hartindex")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Xiang W <wxjstz@126.com>
Reviewed-by: Anup Patel <anup@brainfault.org>

diff --git a/lib/sbi/sbi_domain.c b/lib/sbi/sbi_domain.c
index b1f485d488803ebc447787346fb063ec484089c6..fd4a2965c3aaa59b43f877f2f9e8350bd6c5588b 100644 (file)
--- a/lib/sbi/sbi_domain.c
+++ b/lib/sbi/sbi_domain.c
@@ -76,7 +76,7 @@ ulong sbi_domain_get_assigned_hartmask(const struct sbi_domain *dom,
        ulong ret = 0;
        for (int i = 0; i < 8 * sizeof(ret); i++) {
                if (sbi_domain_is_assigned_hart(dom, hbase + i))
-                       ret |= 1 << i;
+                       ret |= 1UL << i;
        }
 
        return ret;