i2c: qcom-cci: Deprecate duplicated compatibles
authorKonrad Dybcio <konrad.dybcio@linaro.org>
Tue, 13 Dec 2022 18:33:05 +0000 (19:33 +0100)
committerWolfram Sang <wsa@kernel.org>
Mon, 9 Jan 2023 11:57:07 +0000 (12:57 +0100)
Many compatibles have been introduced, pointing to the same config data.
Leave a note reminding future developers to not do that again.

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
drivers/i2c/busses/i2c-qcom-cci.c

index a4b97fe..0135847 100644 (file)
@@ -811,9 +811,15 @@ static const struct cci_data cci_v2_data = {
 
 static const struct of_device_id cci_dt_match[] = {
        { .compatible = "qcom,msm8226-cci", .data = &cci_v1_data},
-       { .compatible = "qcom,msm8916-cci", .data = &cci_v1_data},
        { .compatible = "qcom,msm8974-cci", .data = &cci_v1_5_data},
        { .compatible = "qcom,msm8996-cci", .data = &cci_v2_data},
+
+
+       /*
+        * Legacy compatibles kept for backwards compatibility.
+        * Do not add any new ones unless they introduce a new config
+        */
+       { .compatible = "qcom,msm8916-cci", .data = &cci_v1_data},
        { .compatible = "qcom,sdm845-cci", .data = &cci_v2_data},
        { .compatible = "qcom,sm8250-cci", .data = &cci_v2_data},
        { .compatible = "qcom,sm8450-cci", .data = &cci_v2_data},