devlink: remove redundant health state set to error
authorMoshe Shemesh <moshe@nvidia.com>
Sun, 20 Nov 2022 08:36:52 +0000 (10:36 +0200)
committerJakub Kicinski <kuba@kernel.org>
Wed, 23 Nov 2022 04:41:38 +0000 (20:41 -0800)
Reporter health_state is set twice to error in devlink_health_report().
Remove second time as it is redundant.

Signed-off-by: Moshe Shemesh <moshe@nvidia.com>
Reviewed-by: Eran Ben Elisha <eranbe@nvidia.com>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Link: https://lore.kernel.org/r/1668933412-5498-1-git-send-email-moshe@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/core/devlink.c

index d93bc95..cea154d 100644 (file)
@@ -7846,8 +7846,6 @@ int devlink_health_report(struct devlink_health_reporter *reporter,
                return -ECANCELED;
        }
 
-       reporter->health_state = DEVLINK_HEALTH_REPORTER_STATE_ERROR;
-
        if (reporter->auto_dump) {
                mutex_lock(&reporter->dump_lock);
                /* store current dump of current error, for later analysis */