staging: rtl8192u: Switch from strlcpy to strscpy
authorKumar Kartikeya Dwivedi <memxor@gmail.com>
Sun, 31 Jan 2021 17:28:31 +0000 (22:58 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 4 Feb 2021 16:16:07 +0000 (17:16 +0100)
strlcpy is marked as deprecated in Documentation/process/deprecated.rst,
and there is no functional difference when the caller expects truncation
(when not checking the return value). strscpy is relatively better as it
also avoids scanning the whole source string.

This silences the related checkpatch warnings from:
5dbdb2d87c29 ("checkpatch: prefer strscpy to strlcpy")

Signed-off-by: Kumar Kartikeya Dwivedi <memxor@gmail.com>
Link: https://lore.kernel.org/r/20210131172838.146706-11-memxor@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac_wx.c

index f434a26..afa92dd 100644 (file)
@@ -484,7 +484,7 @@ int ieee80211_wx_get_name(struct ieee80211_device *ieee,
                             struct iw_request_info *info,
                             union iwreq_data *wrqu, char *extra)
 {
-       strlcpy(wrqu->name, "802.11", IFNAMSIZ);
+       strscpy(wrqu->name, "802.11", IFNAMSIZ);
        if (ieee->modulation & IEEE80211_CCK_MODULATION) {
                strlcat(wrqu->name, "b", IFNAMSIZ);
                if (ieee->modulation & IEEE80211_OFDM_MODULATION)