lib: sbi_hsm: Don't use sbi_platform_hart_disabled() API
authorAnup Patel <anup.patel@wdc.com>
Sat, 14 Mar 2020 13:56:22 +0000 (19:26 +0530)
committerAnup Patel <anup@brainfault.org>
Thu, 19 Mar 2020 03:56:25 +0000 (09:26 +0530)
Checking return value of sbi_hartid_to_scratch() is sufficient
so no need to explicitly check for disabled HART using the
sbi_platform_hart_disabled() API.

Signed-off-by: Anup Patel <anup.patel@wdc.com>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Atish Patra <atish.patra@wdc.com>
lib/sbi/sbi_hsm.c

index 4a457ce..10316c5 100644 (file)
@@ -216,8 +216,6 @@ int sbi_hsm_hart_start(struct sbi_scratch *scratch, u32 hartid,
        if (!rscratch)
                return SBI_EINVAL;
        hdata = sbi_scratch_offset_ptr(rscratch, hart_data_offset);
-       if (sbi_platform_hart_disabled(plat, hartid))
-               return SBI_EINVAL;
        hstate = arch_atomic_cmpxchg(&hdata->state, SBI_HART_STOPPED,
                                     SBI_HART_STARTING);
        if (hstate == SBI_HART_STARTED)
@@ -254,12 +252,10 @@ int sbi_hsm_hart_stop(struct sbi_scratch *scratch, bool exitnow)
 {
        int oldstate;
        u32 hartid = current_hartid();
-       const struct sbi_platform *plat = sbi_platform_ptr(scratch);
        struct sbi_hsm_data *hdata = sbi_scratch_offset_ptr(scratch,
                                                            hart_data_offset);
 
-       if (sbi_platform_hart_disabled(plat, hartid) ||
-           !sbi_hsm_hart_started(hartid))
+       if (!sbi_hsm_hart_started(hartid))
                return SBI_EINVAL;
 
        oldstate = arch_atomic_cmpxchg(&hdata->state, SBI_HART_STARTED,