remoteproc: qcom_wcnss: Use devm_qcom_smem_state_get()
authorStephan Gerhold <stephan@gerhold.net>
Fri, 18 Jun 2021 11:15:56 +0000 (13:15 +0200)
committerBjorn Andersson <bjorn.andersson@linaro.org>
Wed, 23 Jun 2021 18:35:18 +0000 (13:35 -0500)
Use the new managed devm_qcom_smem_state_get() variant instead of
calling qcom_smem_state_put() explicitly in remove() to simplify the
code a bit.

Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
Link: https://lore.kernel.org/r/20210618111556.53416-3-stephan@gerhold.net
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
drivers/remoteproc/qcom_wcnss.c

index 5f3455a..f1cbc6b 100644 (file)
@@ -624,8 +624,8 @@ static int wcnss_probe(struct platform_device *pdev)
        wcnss->stop_ack_irq = ret;
 
        if (wcnss->stop_ack_irq) {
-               wcnss->state = qcom_smem_state_get(&pdev->dev, "stop",
-                                                  &wcnss->stop_bit);
+               wcnss->state = devm_qcom_smem_state_get(&pdev->dev, "stop",
+                                                       &wcnss->stop_bit);
                if (IS_ERR(wcnss->state)) {
                        ret = PTR_ERR(wcnss->state);
                        goto detach_pds;
@@ -659,7 +659,6 @@ static int wcnss_remove(struct platform_device *pdev)
 
        of_platform_depopulate(&pdev->dev);
 
-       qcom_smem_state_put(wcnss->state);
        rproc_del(wcnss->rproc);
 
        qcom_remove_sysmon_subdev(wcnss->sysmon);