staging: ks7010: refactor ks_wlan_set_phy_type function

Handle invalid values first and assign good ones at the
end if it is the case. This makes code simplier.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/ks7010/ks_wlan_net.c b/drivers/staging/ks7010/ks_wlan_net.c
index 53288c8..62a9d55 100644 (file)
--- a/drivers/staging/ks7010/ks_wlan_net.c
+++ b/drivers/staging/ks7010/ks_wlan_net.c
@@ -1960,17 +1960,14 @@ static int ks_wlan_set_phy_type(struct net_device *dev,
 
        if (priv->sleep_mode == SLP_SLEEP)
                return -EPERM;
-       /* for SLEEP MODE */
-       if (*uwrq == D_11B_ONLY_MODE) { /* 0 */
-               priv->reg.phy_type = D_11B_ONLY_MODE;
-       } else if (*uwrq == D_11G_ONLY_MODE) {  /* 1 */
-               priv->reg.phy_type = D_11G_ONLY_MODE;
-       } else if (*uwrq == D_11BG_COMPATIBLE_MODE) {   /* 2 */
-               priv->reg.phy_type = D_11BG_COMPATIBLE_MODE;
-       } else {
+
+       if (*uwrq != D_11B_ONLY_MODE &&
+           *uwrq != D_11G_ONLY_MODE &&
+           *uwrq != D_11BG_COMPATIBLE_MODE)
                return -EINVAL;
-       }
 
+       /* for SLEEP MODE */
+       priv->reg.phy_type = *uwrq;
        priv->need_commit |= SME_MODE_SET;
        return -EINPROGRESS;    /* Call commit handler */
 }