[media] cobalt: accept unchanged timings when vb2_is_busy()
authorHans Verkuil <hverkuil@xs4all.nl>
Fri, 17 Jul 2015 11:29:40 +0000 (08:29 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Wed, 22 Jul 2015 14:04:25 +0000 (11:04 -0300)
When vb2_is_busy() it should still be possible to call S_DV_TIMINGS
provided the new timings are the same as the current timings.

For input 1 (test generator) the size is always 1080p, so just return
that.

Fixes a v4l2-compliance issue.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/pci/cobalt/cobalt-v4l2.c

index b40c2d1..9756fd3 100644 (file)
@@ -28,6 +28,7 @@
 
 #include <media/v4l2-ctrls.h>
 #include <media/v4l2-event.h>
+#include <media/v4l2-dv-timings.h>
 #include <media/adv7604.h>
 #include <media/adv7842.h>
 
@@ -641,13 +642,17 @@ static int cobalt_s_dv_timings(struct file *file, void *priv_fh,
        struct cobalt_stream *s = video_drvdata(file);
        int err;
 
-       if (vb2_is_busy(&s->q))
-               return -EBUSY;
-
        if (s->input == 1) {
                *timings = cea1080p60;
                return 0;
        }
+
+       if (v4l2_match_dv_timings(timings, &s->timings, 0))
+               return 0;
+
+       if (vb2_is_busy(&s->q))
+               return -EBUSY;
+
        err = v4l2_subdev_call(s->sd,
                        video, s_dv_timings, timings);
        if (!err) {