media: rkisp1: use pm_runtime_resume_and_get()
authorMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Fri, 23 Apr 2021 15:19:20 +0000 (17:19 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 20 May 2021 14:02:43 +0000 (16:02 +0200)
Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter")
added pm_runtime_resume_and_get() in order to automatically handle
dev->power.usage_count decrement on errors.

Use the new API, in order to cleanup the error check logic.

Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c

index 9643bdd..60cd220 100644 (file)
@@ -1003,9 +1003,8 @@ rkisp1_vb2_start_streaming(struct vb2_queue *queue, unsigned int count)
        if (ret)
                goto err_pipeline_stop;
 
-       ret = pm_runtime_get_sync(cap->rkisp1->dev);
+       ret = pm_runtime_resume_and_get(cap->rkisp1->dev);
        if (ret < 0) {
-               pm_runtime_put_noidle(cap->rkisp1->dev);
                dev_err(cap->rkisp1->dev, "power up failed %d\n", ret);
                goto err_destroy_dummy;
        }