pinctrl: zte: fix group_desc initialization

There are a couple of issues with group_desc initialization in function
zx_pinctrl_build_state().

 - num_pins is not initialized and remains zero.
 - pins shouldn't be initialized with a pointer to variable in the
   stack.

With them fixed, pin_request() in pinmux_enable_setting() can be invoked
correctly.

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

diff --git a/drivers/pinctrl/zte/pinctrl-zx.c b/drivers/pinctrl/zte/pinctrl-zx.c
index 2aca4e4..787e396 100644 (file)
--- a/drivers/pinctrl/zte/pinctrl-zx.c
+++ b/drivers/pinctrl/zte/pinctrl-zx.c
@@ -282,10 +282,10 @@ static int zx_pinctrl_build_state(struct platform_device *pdev)
        for (i = 0; i < ngroups; i++) {
                const struct pinctrl_pin_desc *pindesc = info->pins + i;
                struct group_desc *group = groups + i;
-               int id = pindesc->number;
 
                group->name = pindesc->name;
-               group->pins = &id;
+               group->pins = (int *) &pindesc->number;
+               group->num_pins = 1;
                radix_tree_insert(&pctldev->pin_group_tree, i, group);
        }