cw1200: make cw1200_spi_irq_unsubscribe() void
authorJason Yan <yanaijie@huawei.com>
Fri, 10 Apr 2020 09:09:10 +0000 (17:09 +0800)
committerKalle Valo <kvalo@codeaurora.org>
Wed, 15 Apr 2020 08:38:26 +0000 (11:38 +0300)
Fix the following coccicheck warning:

drivers/net/wireless/st/cw1200/cw1200_spi.c:273:5-8: Unneeded variable:
"ret". Return "0" on line 279

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200410090910.27132-1-yanaijie@huawei.com
drivers/net/wireless/st/cw1200/cw1200_spi.c

index ef01caa..271ed2c 100644 (file)
@@ -268,15 +268,11 @@ exit:
        return ret;
 }
 
-static int cw1200_spi_irq_unsubscribe(struct hwbus_priv *self)
+static void cw1200_spi_irq_unsubscribe(struct hwbus_priv *self)
 {
-       int ret = 0;
-
        pr_debug("SW IRQ unsubscribe\n");
        disable_irq_wake(self->func->irq);
        free_irq(self->func->irq, self);
-
-       return ret;
 }
 
 static int cw1200_spi_off(const struct cw1200_platform_data_spi *pdata)