projects
/
profile
/
ivi
/
kernel-x86-ivi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
49bf7ea
)
synclink: add mutex_unlock() on error path
author
Dan Carpenter
<error27@gmail.com>
Wed, 11 Aug 2010 18:01:46 +0000
(20:01 +0200)
committer
Greg Kroah-Hartman
<gregkh@suse.de>
Tue, 24 Aug 2010 01:17:21 +0000
(18:17 -0700)
There is a path which still holds its mutex here.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/char/synclink_gt.c
patch
|
blob
|
history
diff --git
a/drivers/char/synclink_gt.c
b/drivers/char/synclink_gt.c
index fef80cfcab5c8caf231b4435d423095dfb90815e..e63b830c86cc0778cb45827dc46a7e207488b586 100644
(file)
--- a/
drivers/char/synclink_gt.c
+++ b/
drivers/char/synclink_gt.c
@@
-691,8
+691,10
@@
static int open(struct tty_struct *tty, struct file *filp)
if (info->port.count == 1) {
/* 1st open on this device, init hardware */
retval = startup(info);
- if (retval < 0)
+ if (retval < 0) {
+ mutex_unlock(&info->port.mutex);
goto cleanup;
+ }
}
mutex_unlock(&info->port.mutex);
retval = block_til_ready(tty, filp, info);