dm crypt: remove BIOSET_NEED_RESCUER flag
authorNeilBrown <neilb@suse.com>
Tue, 29 Aug 2017 22:10:18 +0000 (08:10 +1000)
committerMike Snitzer <snitzer@redhat.com>
Wed, 13 Dec 2017 17:15:55 +0000 (12:15 -0500)
The BIOSET_NEED_RESCUER flag is only needed when a make_request_fn might
do two allocations from the one bioset, and the second one could block
until the first bio completes.

dm-crypt does allocate from this bioset inside the dm make_request_fn,
but does so using GFP_NOWAIT so that the allocation will not block.

So BIOSET_NEED_RESCUER is not needed.

Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
drivers/md/dm-crypt.c

index 9fc12f5..9c53367 100644 (file)
@@ -2697,8 +2697,7 @@ static int crypt_ctr(struct dm_target *ti, unsigned int argc, char **argv)
                goto bad;
        }
 
-       cc->bs = bioset_create(MIN_IOS, 0, (BIOSET_NEED_BVECS |
-                                           BIOSET_NEED_RESCUER));
+       cc->bs = bioset_create(MIN_IOS, 0, BIOSET_NEED_BVECS);
        if (!cc->bs) {
                ti->error = "Cannot allocate crypt bioset";
                goto bad;