mdesc: fix a missing-check bug in get_vdev_port_node_info()
authorGen Zhang <blackgod016574@gmail.com>
Fri, 31 May 2019 01:24:18 +0000 (09:24 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 3 Jun 2019 05:15:35 +0000 (22:15 -0700)
In get_vdev_port_node_info(), 'node_info->vdev_port.name' is allcoated
by kstrdup_const(), and it returns NULL when fails. So
'node_info->vdev_port.name' should be checked.

Signed-off-by: Gen Zhang <blackgod016574@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
arch/sparc/kernel/mdesc.c

index 9a26b44..8e645dd 100644 (file)
@@ -356,6 +356,8 @@ static int get_vdev_port_node_info(struct mdesc_handle *md, u64 node,
 
        node_info->vdev_port.id = *idp;
        node_info->vdev_port.name = kstrdup_const(name, GFP_KERNEL);
+       if (!node_info->vdev_port.name)
+               return -1;
        node_info->vdev_port.parent_cfg_hdl = *parent_cfg_hdlp;
 
        return 0;