serial: 8250_omap: Add OMAP_DMA_TX_KICK quirk for AM437x
authorVignesh R <vigneshr@ti.com>
Tue, 4 Apr 2017 19:32:22 +0000 (19:32 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 12 Apr 2017 10:41:19 +0000 (12:41 +0200)
[ Upstream commit b6ffcf21082300519bc4f9c3d24f61207cc9eae4 ]

UART uses as EDMA as dma engine on AM437x SoC and therefore, requires
OMAP_DMA_TX_KICK quirk just like AM33xx. So, enable OMAP_DMA_TX_KICK
quirk for AM437x platform as well. While at that, drop use of
of_machine_is_compatible() and instead pass quirks via device data.

Signed-off-by: Vignesh R <vigneshr@ti.com>
Acked-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/8250/8250_omap.c

index 61ad6c3..f4eb807 100644 (file)
@@ -1075,15 +1075,15 @@ static int omap8250_no_handle_irq(struct uart_port *port)
 }
 
 static const u8 am3352_habit = OMAP_DMA_TX_KICK | UART_ERRATA_CLOCK_DISABLE;
-static const u8 am4372_habit = UART_ERRATA_CLOCK_DISABLE;
+static const u8 dra742_habit = UART_ERRATA_CLOCK_DISABLE;
 
 static const struct of_device_id omap8250_dt_ids[] = {
        { .compatible = "ti,omap2-uart" },
        { .compatible = "ti,omap3-uart" },
        { .compatible = "ti,omap4-uart" },
        { .compatible = "ti,am3352-uart", .data = &am3352_habit, },
-       { .compatible = "ti,am4372-uart", .data = &am4372_habit, },
-       { .compatible = "ti,dra742-uart", .data = &am4372_habit, },
+       { .compatible = "ti,am4372-uart", .data = &am3352_habit, },
+       { .compatible = "ti,dra742-uart", .data = &dra742_habit, },
        {},
 };
 MODULE_DEVICE_TABLE(of, omap8250_dt_ids);
@@ -1218,9 +1218,6 @@ static int omap8250_probe(struct platform_device *pdev)
                        priv->omap8250_dma.rx_size = RX_TRIGGER;
                        priv->omap8250_dma.rxconf.src_maxburst = RX_TRIGGER;
                        priv->omap8250_dma.txconf.dst_maxburst = TX_TRIGGER;
-
-                       if (of_machine_is_compatible("ti,am33xx"))
-                               priv->habit |= OMAP_DMA_TX_KICK;
                        /*
                         * pause is currently not supported atleast on omap-sdma
                         * and edma on most earlier kernels.