Supply a default implementation of IsRuntimeSupportValue.
authorAdrian Prantl <aprantl@apple.com>
Fri, 3 May 2019 20:28:19 +0000 (20:28 +0000)
committerAdrian Prantl <aprantl@apple.com>
Fri, 3 May 2019 20:28:19 +0000 (20:28 +0000)
Thanks to Pavel for pointing this out.

llvm-svn: 359925

lldb/packages/Python/lldbsuite/test/lang/c/vla/TestVLA.py
lldb/source/Core/ValueObject.cpp

index 1453f2c..09439e2 100644 (file)
@@ -9,7 +9,6 @@ class TestVLA(TestBase):
     mydir = TestBase.compute_mydir(__file__)
 
     @skipIf(compiler="clang", compiler_version=['<', '8.0'])
-    @expectedFailureAll(oslist=no_match(lldbplatformutil.getDarwinOSTriples()))
     def test_variable_list(self):
         self.build()
         _, process, _, _ = lldbutil.run_to_source_breakpoint(
index 1d9d7d4..e2b91fe 100644 (file)
@@ -31,6 +31,7 @@
 #include "lldb/Symbol/Declaration.h"
 #include "lldb/Symbol/SymbolContext.h"
 #include "lldb/Symbol/Type.h"
+#include "lldb/Symbol/Variable.h"
 #include "lldb/Target/ExecutionContext.h"
 #include "lldb/Target/Language.h"
 #include "lldb/Target/LanguageRuntime.h"
@@ -1704,6 +1705,9 @@ bool ValueObject::IsRuntimeSupportValue() {
       runtime = process->GetObjCLanguageRuntime();
     if (runtime)
       return runtime->IsRuntimeSupportValue(*this);
+    // If there is no language runtime, trust the compiler to mark all
+    // runtime support variables as artificial.
+    return GetVariable() && GetVariable()->IsArtificial();
   }
   return false;
 }