Web Inspector: Line number is not displayed while debugging javascript

https://bugs.webkit.org/show_bug.cgi?id=83786

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-04-13
Reviewed by Pavel Feldman.

Changed the textViewer.css to start displaying the line number with
appropriate color property. Added outline property for enhanced view

No additional test cases required for the above fix.

* inspector/front-end/Images/breakpointConditionalCounterBorder.png:
* inspector/front-end/Images/breakpointCounterBorder.png:
* inspector/front-end/Images/programCounterBorder.png:
* inspector/front-end/textViewer.css:
(.webkit-execution-line .webkit-line-number-outer):
(.webkit-breakpoint.webkit-execution-line .webkit-line-number-outer):
(.webkit-breakpoint-conditional.webkit-execution-line .webkit-line-number-outer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
index 53c8aa6..f3e410e 100644 (file)
--- a/Source/WebCore/ChangeLog
+++ b/Source/WebCore/ChangeLog
@@ -1,3 +1,23 @@
+2012-04-13  Vivek Galatage  <vivekgalatage@gmail.com>
+
+        Web Inspector: Line number is not displayed while debugging javascript
+        https://bugs.webkit.org/show_bug.cgi?id=83786
+
+        Reviewed by Pavel Feldman.
+
+        Changed the textViewer.css to start displaying the line number with
+        appropriate color property. Added outline property for enhanced view
+
+        No additional test cases required for the above fix.
+
+        * inspector/front-end/Images/breakpointConditionalCounterBorder.png:
+        * inspector/front-end/Images/breakpointCounterBorder.png:
+        * inspector/front-end/Images/programCounterBorder.png:
+        * inspector/front-end/textViewer.css:
+        (.webkit-execution-line .webkit-line-number-outer):
+        (.webkit-breakpoint.webkit-execution-line .webkit-line-number-outer):
+        (.webkit-breakpoint-conditional.webkit-execution-line .webkit-line-number-outer):
+
 2012-04-13  Kent Tamura  <tkent@chromium.org>
 
         Add a runtime flag for <input type=date>

diff --git a/Source/WebCore/inspector/front-end/Images/breakpointConditionalCounterBorder.png b/Source/WebCore/inspector/front-end/Images/breakpointConditionalCounterBorder.png
index a173c9d..03b6412 100644 (file)
Binary files a/Source/WebCore/inspector/front-end/Images/breakpointConditionalCounterBorder.png and b/Source/WebCore/inspector/front-end/Images/breakpointConditionalCounterBorder.png differ

diff --git a/Source/WebCore/inspector/front-end/Images/breakpointCounterBorder.png b/Source/WebCore/inspector/front-end/Images/breakpointCounterBorder.png
index d078545..4fe9e06 100644 (file)
Binary files a/Source/WebCore/inspector/front-end/Images/breakpointCounterBorder.png and b/Source/WebCore/inspector/front-end/Images/breakpointCounterBorder.png differ

diff --git a/Source/WebCore/inspector/front-end/Images/programCounterBorder.png b/Source/WebCore/inspector/front-end/Images/programCounterBorder.png
index 5e7717e..96ce1f0 100644 (file)
Binary files a/Source/WebCore/inspector/front-end/Images/programCounterBorder.png and b/Source/WebCore/inspector/front-end/Images/programCounterBorder.png differ

diff --git a/Source/WebCore/inspector/front-end/textViewer.css b/Source/WebCore/inspector/front-end/textViewer.css
index 95066a7..5fae556 100644 (file)
--- a/Source/WebCore/inspector/front-end/textViewer.css
+++ b/Source/WebCore/inspector/front-end/textViewer.css
@@ -138,7 +138,9 @@
 }
 
 .webkit-execution-line .webkit-line-number-outer {
-    color: transparent;
+    color: rgb(142, 5, 4);
+    font-weight: bold;
+    outline: 1px solid rgb(64, 115, 244);
     border-width: 0 14px 0px 2px;
     -webkit-border-image: url(Images/programCounterBorder.png) 0 14 0 2;
 }
@@ -149,12 +151,16 @@
 }
 
 .webkit-breakpoint.webkit-execution-line .webkit-line-number-outer {
-    color: transparent;
+    color: white;
+    font-weight: bold;
+    outline: 1px solid rgb(64, 115, 244);
     -webkit-border-image: url(Images/breakpointCounterBorder.png) 0 14 0 2;
 }
 
 .webkit-breakpoint-conditional.webkit-execution-line .webkit-line-number-outer {
-    color: transparent;
+    color: white;
+    font-weight: bold;
+    outline: 1px solid rgb(64, 115, 244);
     -webkit-border-image: url(Images/breakpointConditionalCounterBorder.png) 0 14 0 2;
 }