scsi: esp_scsi: Do not set SCSI message byte
authorHannes Reinecke <hare@suse.de>
Wed, 13 Jan 2021 09:04:54 +0000 (10:04 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sat, 23 Jan 2021 02:14:11 +0000 (21:14 -0500)
The message byte setting always devolves to COMMAND_COMPLETE so we can drop
setting the message byte in the SCSI result.

Link: https://lore.kernel.org/r/20210113090500.129644-30-hare@suse.de
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/esp_scsi.c

index 2bc7e99..007ccef 100644 (file)
@@ -907,10 +907,8 @@ static void esp_cmd_is_done(struct esp *esp, struct esp_cmd_entry *ent,
        esp_free_lun_tag(ent, dev->hostdata);
        cmd->result = 0;
        set_host_byte(cmd, host_byte);
-       if (host_byte == DID_OK) {
-               set_msg_byte(cmd, ent->message);
+       if (host_byte == DID_OK)
                set_status_byte(cmd, ent->status);
-       }
 
        if (ent->eh_done) {
                complete(ent->eh_done);
@@ -926,7 +924,6 @@ static void esp_cmd_is_done(struct esp *esp, struct esp_cmd_entry *ent,
                 */
                cmd->result = ((DRIVER_SENSE << 24) |
                               (DID_OK << 16) |
-                              (COMMAND_COMPLETE << 8) |
                               (SAM_STAT_CHECK_CONDITION << 0));
 
                ent->flags &= ~ESP_CMD_FLAG_AUTOSENSE;