drm/arm/malidp: use sysfs_emit in show function callback
authorDeepak R Varma <drv@mailo.com>
Fri, 27 Jan 2023 20:51:26 +0000 (02:21 +0530)
committerLiviu Dudau <liviu.dudau@arm.com>
Fri, 3 Feb 2023 13:05:33 +0000 (13:05 +0000)
According to Documentation/filesystems/sysfs.rst, the show() callback
function of kobject attributes should strictly use sysfs_emit() instead
of sprintf() family functions.
Issue identified using the device_attr_show.cocci Coccinelle script.

Signed-off-by: Deepak R Varma <drv@mailo.com>
Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
Link: https://patchwork.freedesktop.org/patch/msgid/Y9Q5Tt8c9WBDxeyV@ubun2204.myguest.virtualbox.org
drivers/gpu/drm/arm/malidp_drv.c

index 589c1c66a6dcdcbb43dbdadf082637f8c0e3023c..cf040e2e9efed98658fa3108be3722ad77b2dc99 100644 (file)
@@ -649,7 +649,7 @@ static ssize_t core_id_show(struct device *dev, struct device_attribute *attr,
        struct drm_device *drm = dev_get_drvdata(dev);
        struct malidp_drm *malidp = drm_to_malidp(drm);
 
-       return snprintf(buf, PAGE_SIZE, "%08x\n", malidp->core_id);
+       return sysfs_emit(buf, "%08x\n", malidp->core_id);
 }
 
 static DEVICE_ATTR_RO(core_id);