ges-base-xml-formatter: fix property setting

GstStructureForeachFunc has a gboolean return value,
and the foreach function will stop unless we return
TRUE here. This meant it was potluck whether all
properties in the structure got set or not.

Fixes setting of text overlay clip text property
in particular.

https://bugzilla.gnome.org/show_bug.cgi?id=743874

diff --git a/ges/ges-base-xml-formatter.c b/ges/ges-base-xml-formatter.c
index 3741c41..6f81f94 100644 (file)
--- a/ges/ges-base-xml-formatter.c
+++ b/ges/ges-base-xml-formatter.c
@@ -495,10 +495,11 @@ _set_child_property (GQuark field_id, const GValue * value,
   gst_object_unref (element);
 }
 
-void
+gboolean
 set_property_foreach (GQuark field_id, const GValue * value, GObject * object)
 {
   g_object_set_property (object, g_quark_to_string (field_id), value);
+  return TRUE;
 }
 
 static inline GESClip *

diff --git a/ges/ges-internal.h b/ges/ges-internal.h
index 119a58d..d5efad8 100644 (file)
--- a/ges/ges-internal.h
+++ b/ges/ges-internal.h
@@ -267,7 +267,7 @@ G_GNUC_INTERNAL void ges_base_xml_formatter_add_control_binding (GESBaseXmlForma
                                                                   const gchar *track_id,
                                                                   GSList * timed_values);
 
-G_GNUC_INTERNAL void set_property_foreach                       (GQuark field_id,
+G_GNUC_INTERNAL gboolean set_property_foreach                   (GQuark field_id,
                                                                  const GValue * value,
                                                                  GObject * object);;